Re: [PATCH] net: ch9200: use BIT macro for bitmask constants

[Qasim Ijaz]

On Fri, Jun 06, 2025 at 06:46:25PM +0200, Andrew Lunn wrote:
> On Fri, Jun 06, 2025 at 05:07:23PM +0100, Qasim Ijaz wrote:
> > Use the BIT() macro for bitmask constants.
> 
> What you fail to answer is the question 'Why?'.

I made this change mainly as a small clean-up, it makes the code a tad
bit easier to read.

> 
> This driver is old and stable. It has in fact had no feature
> development work done on it since 2015. All the patches since then
> have been tree wide sort of changes.
> 
> Most would consider your change just pointless churn. It does not fix
> anything which is broken. So why make this change?

Yea that makes sense.

> 
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#clean-up-patches

Ah i see thank you, I will keep this in mind next time.

> 
> Do you have the hardware? If you do, maybe consider porting it to
> phylib?
> 

I don't, I did try to buy it but after searching for it but I couldn't
find it anywhere. I do however have the hardware for the this:
 
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/usb/dm9601.c

Would the phylib porting apply to this too? If so I would love to work
on it.

Thanks
Qasim
> 	Andrew