Re: [PATCH] net: ch9200: use BIT macro for bitmask constants

[Andrew Lunn]

On Fri, Jun 06, 2025 at 05:07:23PM +0100, Qasim Ijaz wrote:
> Use the BIT() macro for bitmask constants.

What you fail to answer is the question 'Why?'.

This driver is old and stable. It has in fact had no feature
development work done on it since 2015. All the patches since then
have been tree wide sort of changes.

Most would consider your change just pointless churn. It does not fix
anything which is broken. So why make this change?

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#clean-up-patches

Do you have the hardware? If you do, maybe consider porting it to
phylib?

	Andrew