Re: [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board

[Krzysztof Kozlowski]

On 02/06/2025 16:06, Frank Li wrote:
> Add missed legancy lpc43xx board compatible string to fix below CHECK_DTB

typo: legacy

> warnings:
> arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: /: failed to match any schema with compatible: ['ciaa,lpc4337', 'nxp,lpc4337', 'nxp,lpc4350']


> 
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
>  .../devicetree/bindings/arm/fsl.yaml          | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index d3b5e6923e416..75e46ffe9ba8c 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1711,6 +1711,29 @@ properties:
>                - traverse,ten64            # Ten64 Networking Appliance / Board
>            - const: fsl,ls1088a
>  
> +      - description: lpc based Boards
> +        items:
> +          - enum:
> +              - ea,lpc4357-developers-kit
> +              - ciaa,lpc4337
> +          - enum:
> +              - nxp,lpc4337
> +              - nxp,lpc4357

This feels wrong. Why 4337-based board is compatible with 4357 SoC? If
this was intentional either DTS is wrong or commit msg needs explanation.

> +          - const: nxp,lpc4350
> +
Best regards,
Krzysztof