Re: [PATCH v3 2/3] dt-bindings: pwm: adi,axi-pwmgen: fix clocks
From: Krzysztof Kozlowski
Date: Mon Jun 02 2025 - 04:00:52 EST
On Thu, May 29, 2025 at 11:53:19AM GMT, David Lechner wrote:
> Fix a shortcoming in the bindings that doesn't allow for a separate
> external clock.
>
> The AXI PWMGEN IP block has a compile option ASYNC_CLK_EN that allows
> the use of an external clock for the PWM output separate from the AXI
> clock that runs the peripheral.
>
> This was missed in the original bindings and so users were writing dts
> files where the one and only clock specified would be the external
> clock, if there was one, incorrectly missing the separate AXI clock.
>
> The correct bindings are that the AXI clock is always required and the
> external clock is optional (must be given only when HDL compile option
> ASYNC_CLK_EN=1).
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 1edf2c2a2841 ("dt-bindings: pwm: Add AXI PWM generator")
> Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof