Re: [PATCH v3] spi: dt-bindings: cdns,qspi-nor: Update minItems/maxItems of resets for Cadence OSPI controller

From: Krzysztof Kozlowski
Date: Mon Jun 02 2025 - 03:58:47 EST


On Tue, May 27, 2025 at 12:04:38PM GMT, Amit Kumar Mahapatra wrote:
> The Cadence Octal SPI (OSPI) controller on AMD Versal SoCs requires only
> one reset entry. To reflect this, the maxItems for "resets" and
> "reset-names" has been set to 1 for AMD Versal SoCs.
>
> Acked-by: Mark Brown <broonie@xxxxxxxxxx>
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@xxxxxxx>
> ---
> BRANCH: mtd/next
>
> Changes in v3:
> - Updates to 'resets' and 'reset-names' removed for non-Versal platforms.
> - Updated patch description.
> - Added Mark's Acked-by tag.
>
> Changes in v2:
> - Removed "resets" & "reset-names" from required properties.
> - To address review comments, removed "maxItems" from "reset-names".
> ---
> Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> index d48ecd6cd5ad..81e8342db4bc 100644
> --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> @@ -17,6 +17,13 @@ allOf:
> contains:
> const: xlnx,versal-ospi-1.0
> then:
> + properties:
> + resets:
> + maxItems: 1

And now this is not synced with top-level properties. They say
minItems:2. I never asked to drop update of top-level - read carefully
v1 feedback.

Best regards,
Krzysztof