[PATCH v2 1/4] kbuild: move W=1 check for scripts/misc-check to top-level Makefile

From: Masahiro Yamada
Date: Sun Jun 01 2025 - 09:32:43 EST


This script is executed only when ${KBUILD_EXTRA_WARN} contains 1.
Move this check to the top-level Makefile to allow more checks to be
easily added to this script.

Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
---

(no changes since v1)

Makefile | 3 +++
scripts/misc-check | 9 +--------
2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/Makefile b/Makefile
index 61f4e7662192..7a52be3a4b80 100644
--- a/Makefile
+++ b/Makefile
@@ -1824,9 +1824,12 @@ rustfmtcheck: rustfmt
# Misc
# ---------------------------------------------------------------------------

+# Run misc checks when ${KBUILD_EXTRA_WARN} contains 1
PHONY += misc-check
+ifneq ($(findstring 1,$(KBUILD_EXTRA_WARN)),)
misc-check:
$(Q)$(srctree)/scripts/misc-check
+endif

all: misc-check

diff --git a/scripts/misc-check b/scripts/misc-check
index d40d5484e0c5..f37b2f6931cc 100755
--- a/scripts/misc-check
+++ b/scripts/misc-check
@@ -3,15 +3,8 @@

set -e

-# Detect files that are tracked but ignored by git. This is checked only when
-# ${KBUILD_EXTRA_WARN} contains 1, git is installed, and the source tree is
-# tracked by git.
+# Detect files that are tracked but ignored by git.
check_tracked_ignored_files () {
- case "${KBUILD_EXTRA_WARN}" in
- *1*) ;;
- *) return;;
- esac
-
git -C ${srctree:-.} ls-files -i -c --exclude-per-directory=.gitignore 2>/dev/null |
sed 's/$/: warning: ignored by one of the .gitignore files/' >&2
}
--
2.43.0