Re: [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec

[Prasad Kumpatla]

On 5/31/2025 6:05 PM, Konrad Dybcio wrote:
> On 5/27/25 1:12 PM, Prasad Kumpatla wrote:
> > From: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx>
> >
> > Add nodes for WSA8830 speakers and WCD9370 headset codec
> > on qcm6490-idp board.
> >
> > Enable lpass macros along with audio support pin controls.
> >
> > Signed-off-by: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx>
> > Co-developed-by: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>
> > Signed-off-by: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>
> > ---
>
> [...]
>
> >   &uart5 {
> > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> > index 542a39ca72bb..2e75e7706fb4 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> > @@ -29,6 +29,30 @@ &lpass_dmic23_data {
> >   	bias-pull-down;
> >   };
> >   
> > +&lpass_rx_swr_clk {
> > +	drive-strength = <2>;
> > +	slew-rate = <1>;
> > +	bias-disable;
> > +};
> > +
> > +&lpass_rx_swr_data {
> > +	drive-strength = <2>;
> > +	slew-rate = <1>;
> > +	bias-bus-hold;
> > +};
> > +
> > +&lpass_tx_swr_clk {
> > +	drive-strength = <2>;
> > +	slew-rate = <1>;
> > +	bias-disable;
> > +};
> > +
> > +&lpass_tx_swr_data {
> > +	drive-strength = <2>;
> > +	slew-rate = <1>;
> > +	bias-bus-hold;
> > +};
>
> All other DTs that overwrite these pins seem to be setting the
> exact same settings.. And given this pin is connected to an on-SoC
> peripheral, I think it would make sense to consolidate these in
> sc7280.dtsi

Ack

Thanks,
Prasad

> Konrad