Re: [PATCH v3 2/4] mm/page_isolation: remove migratetype from move_freepages_block_isolate()
From: Zi Yan
Date: Thu May 08 2025 - 16:24:09 EST
On 7 May 2025, at 17:10, Zi Yan wrote:
> Since migratetype is no longer overwritten during pageblock isolation,
> moving pageblocks to and from MIGRATE_ISOLATE no longer needs migratetype.
>
> Add MIGRATETYPE_NO_ISO_MASK to allow read before-isolation migratetype
> when a pageblock is isolated. It is used by move_freepages_block_isolate().
>
> Add pageblock_isolate_and_move_free_pages() and
> pageblock_unisolate_and_move_free_pages() to be explicit about the page
> isolation operations. Both share the common code in
> __move_freepages_block_isolate(), which is renamed from
> move_freepages_block_isolate().
>
> Signed-off-by: Zi Yan <ziy@xxxxxxxxxx>
> ---
> include/linux/mmzone.h | 4 ++-
> include/linux/page-isolation.h | 4 +--
> mm/page_alloc.c | 49 +++++++++++++++++++++++++++-------
> mm/page_isolation.c | 21 +++++++--------
> 4 files changed, 55 insertions(+), 23 deletions(-)
>
Here is the fixup 2/3 to address Johannes’ comments.