Re: [patch V2 09/45] genirq/cpuhotplug: Convert to lock guards
From: Thomas Gleixner
Date: Thu May 08 2025 - 13:53:44 EST
On Thu, May 08 2025 at 16:56, Marek Szyprowski wrote:
>> irq_lock_sparse();
>> for_each_active_irq(irq) {
>> desc = irq_to_desc(irq);
>> - raw_spin_lock_irq(&desc->lock);
>> - irq_restore_affinity_of_irq(desc, cpu);
>> - raw_spin_unlock_irq(&desc->lock);
>> + scoped_guard(raw_spinlock, &desc->lock)
>
> The above should be "scoped_guard(raw_spinlock_irq, &desc->lock)", otherwise the cpu hotplug is broken as in today's linux-next.
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=irq/core&id=c855506257063f444044d0a85a2e9ad9ab1c7ecd