Re: [PATCH v10 07/30] x86/resctrl: Check all domains are offline in resctrl_exit()

[Reinette Chatre]

Hi James,

On 5/8/25 10:18 AM, James Morse wrote:
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 88197afbbb8a..f617ac97758b 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -4420,8 +4420,32 @@ int __init resctrl_init(void)
>  	return ret;
>  }
>  
> +static bool __exit resctrl_online_domains_exist(void)
> +{
> +	struct rdt_resource *r;
> +
> +	for_each_rdt_resource(r) {
> +		if (!list_empty(&r->ctrl_domains) || !list_empty(&r->mon_domains))
> +			return true;
> +	}
> +
> +	return false;
> +}

This looks the same as before. Did you notice my comment in [1] about this list_empty() usage?

Reinette

[1] https://lore.kernel.org/lkml/91c31b70-3d41-40cb-b00b-aa39cbd07bc9@xxxxxxxxx/