Re: [PATCH v2 3/9] dt-bindings: qcom: geni-se: describe SA8255p

[Praveen Talari]

Hi

On 4/25/2025 3:46 PM, Krzysztof Kozlowski wrote:
> On Fri, Apr 18, 2025 at 08:42:29PM GMT, Praveen Talari wrote:
> > +  "#size-cells":
> > +    const: 2
> > +
> > +  ranges: true
> > +
> > +  iommus:
> > +    maxItems: 1
> > +
> > +  dma-coherent: true
> > +
> > +required:
> required: block goes after properties and patternproperties. I guess you
> copied it from the existing geni binding, but new bindings can improve.
Sure, will update in next version.
> > +  - compatible
> > +  - reg
> > +  - "#address-cells"
> > +  - "#size-cells"
> > +  - ranges
> > +
> > +patternProperties:
> Rest looks good so with this reordering:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Best regards,
> Krzysztof