Re: [PATCH v2 3/9] dt-bindings: qcom: geni-se: describe SA8255p

From: Krzysztof Kozlowski
Date: Fri Apr 25 2025 - 06:16:17 EST


On Fri, Apr 18, 2025 at 08:42:29PM GMT, Praveen Talari wrote:
> + "#size-cells":
> + const: 2
> +
> + ranges: true
> +
> + iommus:
> + maxItems: 1
> +
> + dma-coherent: true
> +
> +required:

required: block goes after properties and patternproperties. I guess you
copied it from the existing geni binding, but new bindings can improve.

> + - compatible
> + - reg
> + - "#address-cells"
> + - "#size-cells"
> + - ranges
> +
> +patternProperties:

Rest looks good so with this reordering:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof