Re: [PATCH net-next v4 2/8] dt-bindings: dpll: Add support for Microchip Azurite chip family

[Ivan Vecera]

On 25. 04. 25 9:41 dop., Krzysztof Kozlowski wrote:
> On Thu, Apr 24, 2025 at 05:47:16PM GMT, Ivan Vecera wrote:
> > Add DT bindings for Microchip Azurite DPLL chip family. These chips
> > provide up to 5 independent DPLL channels, 10 differential or
> > single-ended inputs and 10 differential or 20 single-ended outputs.
> > They can be connected via I2C or SPI busses.
> >
> > Check:
> > $ make dt_binding_check DT_SCHEMA_FILES=/dpll/
>
> None of these commands belong to the commit msg. Look at all other
> commits: do you see it anywhere?

+1

> >    SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> > /home/cera/devel/kernel/linux-2.6/Documentation/devicetree/bindings/net/snps,dwmac.yaml: mac-mode: missing type definition
> >    CHKDT   ./Documentation/devicetree/bindings
> >    LINT    ./Documentation/devicetree/bindings
> >    DTC [C] Documentation/devicetree/bindings/dpll/dpll-pin.example.dtb
> >    DTEX    Documentation/devicetree/bindings/dpll/microchip,zl30731.example.dts
> >    DTC [C] Documentation/devicetree/bindings/dpll/microchip,zl30731.example.dtb
> >    DTC [C] Documentation/devicetree/bindings/dpll/dpll-device.example.dtb
>
> With above fixed:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Thank you.

I.
> ---
>
> <form letter>
> This is an automated instruction, just in case, because many review tags
> are being ignored. If you know the process, you can skip it (please do
> not feel offended by me posting it here - no bad intentions intended).
> If you do not know the process, here is a short explanation:
>
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions of patchset, under or above your Signed-off-by tag, unless
> patch changed significantly (e.g. new properties added to the DT
> bindings). Tag is "received", when provided in a message replied to you
> on the mailing list. Tools like b4 can help here. However, there's no
> need to repost patches *only* to add the tags. The upstream maintainer
> will do that for tags received on the version they apply.
>
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> </form letter>
>
> Best regards,
> Krzysztof