Re: [PATCH net-next v4 1/8] dt-bindings: dpll: Add DPLL device and pin

[Ivan Vecera]

On 25. 04. 25 9:39 dop., Krzysztof Kozlowski wrote:
> On Thu, Apr 24, 2025 at 05:47:15PM GMT, Ivan Vecera wrote:
> > Add a common DT schema for DPLL device and its associated pins.
> > The DPLL (device phase-locked loop) is a device used for precise clock
> > synchronization in networking and telecom hardware.
> >
> > The device includes one or more DPLLs (channels) and one or more
> > physical input/output pins.
> >
> > Each DPLL channel is used either to provide a pulse-per-clock signal or
> > to drive an Ethernet equipment clock.
> >
> > The input and output pins have the following properties:
> > * label: specifies board label
> > * connection type: specifies its usage depending on wiring
> > * list of supported or allowed frequencies: depending on how the pin
> >    is connected and where)
> > * embedded sync capability: indicates whether the pin supports this
> >
> > Check:
>
> This does not belong to commit msg. You do not add compile commands of C
> files, do you?
>
> Whatever you want to inform and is not relevant in the Git history
> should be in changelog part.

OK

> > $ make dt_binding_check DT_SCHEMA_FILES=/dpll/
> >    SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> > /home/cera/devel/kernel/linux-2.6/Documentation/devicetree/bindings/net/snps,dwmac.yaml: mac-mode: missing type definition
> >    CHKDT   ./Documentation/devicetree/bindings
> >    LINT    ./Documentation/devicetree/bindings
> >    DTEX    Documentation/devicetree/bindings/dpll/dpll-pin.example.dts
> >    DTC [C] Documentation/devicetree/bindings/dpll/dpll-pin.example.dtb
> >    DTEX    Documentation/devicetree/bindings/dpll/dpll-device.example.dts
> >    DTC [C] Documentation/devicetree/bindings/dpll/dpll-device.example.dtb
> >
> > Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>
> > ---
> > v3->v4:
> > * dropped $Ref from dpll-pin reg property
> > * added maxItems to dpll-pin reg property
> > * fixed paragraph in dpll-pin desc
>
> ...
>
> > +
> > +properties:
> > +  $nodename:
> > +    pattern: "^dpll(@.*)?$"
> > +
> > +  "#address-cells":
> > +    const: 0
> > +
> > +  "#size-cells":
> > +    const: 0
> > +
> > +  dpll-types:
> > +    description: List of DPLL channel types, one per DPLL instance.
> > +    $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> > +    items:
> > +      enum: [pps, eec]
>
> Do channels have other properties as well in general?

No, other characteristics should be deducible either from compatible or
in runtime.

> > +
> > +  input-pins:
> > +    type: object
> > +    description: DPLL input pins
> > +    unevaluatedProperties: false
>
> Best regards,
> Krzysztof