Re: [PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts support
From: Peter Chen
Date: Thu Apr 17 2025 - 02:38:35 EST
On 25-04-17 08:19:59, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
>
> On 15/04/2025 09:27, Peter Chen wrote:
> > CIX SKY1 SoC is high performance Armv9 SoC designed by Cixtech,
> > and Orion O6 is the motherboard launched by Radxa. See below for
> > detail:
> > https://docs.radxa.com/en/orion/o6/getting-started/introduction
> >
> > In this commit, it adds sky1 base, mailbox, clock (scmi firmware baseed)
> > and uart, and the kernel could boot up to console.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> You added several new device nodes, so obviously this is not true anymore.
>
> This is explained in submitting patches - you must drop the review when
> making substantial changes. Adding several nodes is a substantial change.
>
> > Acked-by: Fugang Duan <fugang.duan@xxxxxxxxxxx>
>
> And this as well
Okay, I will delete both tags for the next submission.
--
Best regards,
Peter