Re: [PATCH v2 2/3] iio: pressure: Add driver for Sensirion SDP500

From: Petar Stoykov
Date: Wed May 01 2024 - 07:48:46 EST


On Tue, Apr 30, 2024 at 5:40 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Tue, Apr 30, 2024 at 05:27:24PM +0200, Petar Stoykov wrote:
> > From 6ae7537517f551540121ca6fb3b99080b7580410 Mon Sep 17 00:00:00 2001
> > From: Petar Stoykov <pd.pstoykov@xxxxxxxxx>
> > Date: Mon, 15 Jan 2024 12:21:26 +0100
> > Subject: [PATCH 2/3] iio: pressure: Add driver for Sensirion SDP500
> >
> > Sensirion SDP500 is a digital differential pressure sensor. The sensor is
> > accessed over I2C.
>
> Any Datasheet: tag can be added?
>

Ok. I see some drivers also include the pdf link in the driver's code.
I can do that as well.

> ...
>
> > +config SDP500
> > + tristate "Sensirion SDP500 differential pressure sensor I2C driver"
> > + depends on I2C
> > + help
> > + Say Y here to build support for Sensirion SDP500 differential pressure
> > + sensor I2C driver.
> > + To compile this driver as a module, choose M here: the core module
> > + will be called sdp500.
>
> You patch is broken. Fix the way how you send patches.
>
> ...
>
> > +static int sdp500_start_measurement(struct sdp500_data *data, const
> > struct iio_dev *indio_dev)
>
> Here is more visible.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

I finally figured it out. Gmail has a hard word-wrap at 80 characters per line.
At first I thought it was word-wrap on the receiving side but I was wrong.
I will try to convince IT to change things so I can use b4 or git send e-mail.
If that doesn't work then I guess my code will have shorter lines in next patch.