Re: [PATCH 2/2] media: bcm2835-unicam: Include v4l2-subdev.h

From: Laurent Pinchart
Date: Wed May 01 2024 - 07:47:41 EST


Hi Ricardo,

On Wed, May 01, 2024 at 01:07:29PM +0200, Ricardo Ribalda Delgado wrote:
> Hi Laurent
>
> I have to send a v2 of
> https://patchwork.linuxtv.org/project/linux-media/list/?series=12759 I
> can include this patch in that set if you want

Fine with me.

> On Tue, Apr 30, 2024 at 11:39 PM Laurent Pinchart wrote:
> >
> > The unicam driver uses the v4l2_subdev structure. Include the
> > corresponding header instead of relying on indirect includes.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reviewed-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202404302324.8aTC84kE-lkp@xxxxxxxxx/
> > ---
> > drivers/media/platform/broadcom/bcm2835-unicam.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
> > index c590e26fe2cf..3c7878d8d79b 100644
> > --- a/drivers/media/platform/broadcom/bcm2835-unicam.c
> > +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
> > @@ -55,6 +55,7 @@
> > #include <media/v4l2-ioctl.h>
> > #include <media/v4l2-fwnode.h>
> > #include <media/v4l2-mc.h>
> > +#include <media/v4l2-subdev.h>
> > #include <media/videobuf2-dma-contig.h>
> >
> > #include "bcm2835-unicam-regs.h"

--
Regards,

Laurent Pinchart