Re: [PATCH] dmaengine: zynqmp_dma: Sync DMA and coherent masks

From: Michal Simek
Date: Tue Mar 21 2023 - 11:16:23 EST




On 3/21/23 16:04, Katakam, Harini wrote:
Hi Michal,

-----Original Message-----
From: Simek, Michal <michal.simek@xxxxxxx>
Sent: Tuesday, March 21, 2023 8:15 PM
To: Katakam, Harini <harini.katakam@xxxxxxx>; vkoul@xxxxxxxxxx;
romain.perier@xxxxxxxxx; allen.lkml@xxxxxxxxx; yukuai3@xxxxxxxxxx
Cc: dmaengine@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
kernel@xxxxxxxxxxxxxxx; harinikatakamlinux@xxxxxxxxx; Pandey, Radhey
Shyam <radhey.shyam.pandey@xxxxxxx>
Subject: Re: [PATCH] dmaengine: zynqmp_dma: Sync DMA and coherent
masks



On 3/16/23 10:33, Harini Katakam wrote:
Align ZDMA DMA as well as coherent memory masks to 44 bit. This is
required when using >32 bit memory regions.

It doesn't look like description aligned with the change below.
You are using 44 bit already and the patch itself just checking return value
from that function.

Current code sets dma_set_mask; I changed it to dma_set_mask_and_coherent

Ah ok. Then

Acked-by: Michal Simek <michal.simek@xxxxxxx>

Thanks,
Michal