Re: [PATCH] staging: greybus: use inline function for macros

From: Menna Mahmoud
Date: Mon Mar 20 2023 - 06:15:03 EST



On ٢٠‏/٣‏/٢٠٢٣ ٠٨:٠٠, Julia Lawall wrote:
and version that I have submitted, should I do anything about it as you
said
it is wrong solution?
My concern was the blank line after each of the structure definitions,
which is not in Greg's tree, so he can't apply the patch. Other than
that, if the code compiles it is at least going in the right direction.

Please fix the newlines issue, and then send the patch again.

julia

Okay I will fix it, but will send it as a new patch not v3, right?
Why as a new patch? The change is the same as in v2, and sending v3 makes
it clear that v2 should be ignored.

julia


Okay, thanks.

Menna