Re: [PATCH v2] drivers/gpio : Remove redundant platform_set_drvdata().

[Andy Shevchenko]

On Mon, Mar 20, 2023 at 12:10 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Sun, Mar 19, 2023 at 2:01 PM Lizhe <sensor1010@xxxxxxx> wrote:
> >
> > platform_set_drvdata() is redundant in these functions.
> > the purpose of calling this function is to place data
> > in *driver_data. but the data is not retrieved in these
> > functions
>
> You need to:
> 1) split the series on per driver basis (not all of the drivers are
> going thru the same subsystem);

s/subsystem/tree/

> 2) improve English grammar and style in your commit message;
> 3) carefully explain in the cover letter your methods of finding the
> places you think need to be improved.
>
> Before that it's a waste of time to look at your contributions.


-- 
With Best Regards,
Andy Shevchenko