Re: [PATCH net-next v3 8/9] net: sunhme: Inline error returns

From: Simon Horman
Date: Sat Mar 18 2023 - 09:49:31 EST


On Wed, Mar 15, 2023 at 11:36:25AM -0400, Sean Anderson wrote:
> On 3/15/23 03:51, Jakub Kicinski wrote:
> > On Mon, 13 Mar 2023 20:36:12 -0400 Sean Anderson wrote:
> > > Fixes: 96c6e9faecf1 ("sunhme: forward the error code from pci_enable_device()")
> >
> > No such commit in our trees :(
>
> Ah, looks like I forgot this was bad when copying the other commit. It should be acb3f35f920b.

I agree that is the correct commit.
And the code changes look good to me.

But I wonder if the fix should be separated into another patch,
separate from the cleanup.