Re: [PATCH] dt-bindings: clock: qcom,a53pll: drop operating-points-v2

From: Krzysztof Kozlowski
Date: Thu Jan 19 2023 - 06:05:00 EST


On 19/01/2023 11:55, Bryan O'Donoghue wrote:
> On 19/01/2023 03:11, Bjorn Andersson wrote:
>> On Wed, Jan 18, 2023 at 11:11:00AM -0800, Stephen Boyd wrote:
>>> Quoting Krzysztof Kozlowski (2023-01-15 06:35:23)
>>>> On 13/01/2023 21:28, Stephen Boyd wrote:
>>>>> Quoting Krzysztof Kozlowski (2023-01-13 06:58:59)
>>>>>> The CPU PLL clock node does not use OPP tables (neither driver).
>>>>>
>>>>> What device is qcom_a53pll_get_freq_tbl() operating on?
>>>>
>>>> On its own, internal table. While of course driver could be converted to
>>>> operating-points-v2, no one did it within last 5 years, so why it should
>>>> happen now?
>>>>
>>>
>>> The property was added mid 2021 by Shawn[1], that's not 5 years ago. I
>>> guess there were plans to add an OPP table that never happened[2]? Is
>>> Shawn still working on this? If not, we should revert the OPP code out
>>> of the driver.
>>>
>>
>> @Bryan, what do you think about this?
>
> I'd be in favour of starting the CPR patchset instead, which depends on
> the opps.
>
> I think @Fabien has been waiting on the core 8939 dtsi, I also think the
> dtsi is close enough to merge that we could reasonably initiate the CPR
> stuff.

So you would make use of operating-points-v2 property? Then probably we
also miss opp-table, but anyway this patch can be dropped then.

Best regards,
Krzysztof