Re: [PATCH v4 4/7] s390/pci: Use dma-iommu layer

From: Niklas Schnelle
Date: Thu Jan 19 2023 - 06:04:43 EST


> > > > > > > > > > > > > > > >  
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > >  static char *pci_sw_names[] = {
> > > > > > > > > > > > > > > > - "Allocated pages",
> > > > > > > > > > > > > > > > +/* TODO "Allocated pages", */
> > > > > > > >
> > > > > > > > ? Forgot to finish this?

Definitely forgot to remove the TODO. I think my latest plan was to
just remove this counter. With the DMA API conversion the
dma_map_ops.alloc and dma_map_ops.free move to common code and I don't
see how we could differentiate these from map/unmap on our side. I'm
not sure how helpful this counter really is either. If you're
interested in how many pages are mapped long term I think it makes more
sense to look at the difference between mapped and unmapped pages. What
do you think?
> > > > > > >