Re: [PATCH] riscv: elf: add .riscv.attributes parsing

[Jessica Clarke]

On 10 Jan 2023, at 23:45, Vineet Gupta <vineetg@xxxxxxxxxxxx> wrote:
> On 1/10/23 15:21, Jessica Clarke wrote:
>>>> You also should handle more than one sub-subsection even if tools don’t
>>>> emit it today.
>>> Just to be on same page, a sub-section implies the following
>>> 
>>>       uint32:len, NTBS:vendor-name, uint8: Tag_file, uint32:data-len, <tag><value>....
>>> 
>>> If so, the code does support multiple of these
>> That’s a sub-section, but I said sub-subsection.
> 
> The psABI documentation that we reviewed yesterday only mentions Tag_File = 1 and doesn't mention the term sub-subsection at all.
> We need to be consistent between code and the new documentation or just add reference to ARM documentation which covers everything and write the general purpose parser.

Documentation you wrote and hasn’t been approved by anyone else. Where
I said that we need to document that multiple sub-subsections are
allowed.

Jess