Re: [PATCH] thermal/drivers/qcom: Remove duplicate set next trip point interrupt code

From: Daniel Lezcano
Date: Tue Jan 10 2023 - 08:15:37 EST


On 10/01/2023 14:01, Rafael J. Wysocki wrote:
On Tue, Jan 10, 2023 at 11:34 AM Daniel Lezcano
<daniel.lezcano@xxxxxxxxxx> wrote:

From: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>

The tsens driver reprogram the next trip points in the irq
handler. This function then call thermal_zone_device_update().

However, thermal_zone_device_update() calls thermal_zone_set_trips()
and from there it calls the backend 'set_trips' ops. This one in turn
reprogram the next trip points (low/high).

Consequently, the code setting the next trip points interrupt in the
interrupt handle is not needed and could be removed.

Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>

I'm wondering what you wanted to say through these S-o-b tags.

I don't think you have to sign off your own patch again.

Yes, I changed a configuration in my git tree, something I have to fix. That has to be considered as duplicate SoB

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog