Re: [PATCH v1 1/1] extcon: axp288: Replace open coded acpi_dev_put()

From: Chanwoo Choi
Date: Tue Jan 10 2023 - 08:14:40 EST


On 23. 1. 3. 05:29, Andy Shevchenko wrote:
> Instead of calling put_device(&adev->dev) where adev is a pointer
> to an ACPI device, use specific call, i.e. acpi_dev_put().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/extcon/extcon-axp288.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
> index 180be768c215..a703a8315634 100644
> --- a/drivers/extcon/extcon-axp288.c
> +++ b/drivers/extcon/extcon-axp288.c
> @@ -393,7 +393,7 @@ static int axp288_extcon_probe(struct platform_device *pdev)
> adev = acpi_dev_get_first_match_dev("INT3496", NULL, -1);
> if (adev) {
> info->id_extcon = extcon_get_extcon_dev(acpi_dev_name(adev));
> - put_device(&adev->dev);
> + acpi_dev_put(adev);
> if (IS_ERR(info->id_extcon))
> return PTR_ERR(info->id_extcon);
>

Applied it. Thanks.

--
Best Regards,
Samsung Electronics
Chanwoo Choi