Re: [PATCH bpf-next] bpftool: Add missing quotes to libbpf bootstrap submake vars

From: Quentin Monnet
Date: Tue Jan 10 2023 - 05:09:31 EST


2023-01-09 18:45 UTC-0700 ~ James Hilliard <james.hilliard1@xxxxxxxxx>
> When passing compiler variables like CC=$(HOSTCC) to a submake
> we must ensure the variable is quoted in order to handle cases
> where $(HOSTCC) may be multiple binaries.
>
> For example when using ccache $HOSTCC may be:
> "/usr/bin/ccache /usr/bin/gcc"
>
> If we pass CC without quotes like CC=$(HOSTCC) only the first
> "/usr/bin/ccache" part will be assigned to the CC variable which
> will cause an error due to dropping the "/usr/bin/gcc" part of
> the variable in the submake invocation.
>
> This fixes errors such as:
> /usr/bin/ccache: invalid option -- 'd'
>
> Signed-off-by: James Hilliard <james.hilliard1@xxxxxxxxx>


Acked-by: Quentin Monnet <quentin@xxxxxxxxxxxxx>

Thanks