Re: [PATCH v2 0/3] tools/perf: Fix perf probe crash by clang DWARF5 file

From: Arnaldo Carvalho de Melo
Date: Thu Nov 03 2022 - 08:32:05 EST


Em Tue, Nov 01, 2022 at 05:03:51PM -0700, Namhyung Kim escreveu:
> On Tue, Nov 1, 2022 at 6:48 AM Masami Hiramatsu (Google)
> <mhiramat@xxxxxxxxxx> wrote:
> > Here is the 2nd version of the patches for perf probe which improves the
> > robustness against clang DWARF5 file.
> >
> > Since the Clang generates a bit different DWARF5 file, the perf probe
> > crashes or failes to analyze it. There are actually fragile code against
> > it, so I fixed it ([1/3]) to avoid crash by SEGV. And make it accepts
> > Clang's DWARF5 file ([2/3],[3/3]).

> > Masami Hiramatsu (Google) (3):
> > tools/perf: Fix to avoid crashing if DW_AT_decl_file is NULL
> > tools/perf: Fix to use dwarf_attr_integrate for generic attr accessor
> > tools/perf: Fix to get declared file name from clang DWARF5
>
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks, applied.

- Arnaldo