Re: [PATCH 1/2 v2] lib/vsprintf: Remove static_branch_likely() from __ptr_to_hashval().

From: Sebastian Andrzej Siewior
Date: Mon Aug 01 2022 - 08:49:55 EST


On 2022-08-01 14:13:36 [+0200], Jason A. Donenfeld wrote:
> Also,
>
> On Fri, Jul 29, 2022 at 05:47:15PM +0200, Sebastian Andrzej Siewior wrote:
> > if (!filled) {
> > get_random_bytes(&ptr_key, sizeof(ptr_key));
> > - queue_work(system_unbound_wq, &enable_ptr_key_work);
> > + /* Pairs with smp_rmb() before reading ptr_key. */
> > + smp_wmb();
> > + WRITE_ONCE(filled_random_ptr_key, true);
> > filled = true;
>
> Also, should `filled` be changed there?

you change `filled` as in read_mostly?

> Jason

Sebastian