Re: [PATCH 1/2 v2] lib/vsprintf: Remove static_branch_likely() from __ptr_to_hashval().

[Sebastian Andrzej Siewior]

On 2022-08-01 14:11:33 [+0200], Jason A. Donenfeld wrote:
> > --- a/lib/vsprintf.c
> > +++ b/lib/vsprintf.c
> > @@ -750,12 +750,7 @@ static int __init debug_boot_weak_hash_e
> >  }
> >  early_param("debug_boot_weak_hash", debug_boot_weak_hash_enable);
> >  
> > -static DEFINE_STATIC_KEY_FALSE(filled_random_ptr_key);
> > -
> > -static void enable_ptr_key_workfn(struct work_struct *work)
> > -{
> > -	static_branch_enable(&filled_random_ptr_key);
> > -}
> > +static bool filled_random_ptr_key;
> 
> This should be __read_mostly, right? Just like ptr_key.

could be, yes.

> Jason

Sebastian