Re: [PATCH] mtd: spi-nor: winbond: add support for W25Q512NW-IQ/IN

[Jae Hyun Yoo]

Hi,

On 7/15/2022 4:20 PM, Michael Walle wrote:
> Hi,
>
> > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> > > index ce5d69317d46..a2c8de250e01 100644
> > > --- a/drivers/mtd/spi-nor/core.c
> > > +++ b/drivers/mtd/spi-nor/core.c
> > > @@ -2113,6 +2113,10 @@ spi_nor_select_uniform_erase(struct 
> > > spi_nor_erase_map *map,
> > >
> > >                  tested_erase = &map->erase_type[i];
> > >
> > > +               /* Skip masked erase types. */
> > > +               if (!tested_erase->size)
> > > +                       continue;
> >
> > Yes, it also works. Do you want me to update this patch with adding this
> > fix? Or is it good to go as is so that the INFO table can be replaced
> > with SNOR_ID3 later after the fix is merged?
>
> Please add this as a separate preceding patch to your original one
> where you add the flash. Keep the INFO(0xef6020, 0, 0, 0). Then we
> will replace it later with the SNOR_ID3().

Sure, I'll submit v3 series including the fix then.

Thanks,
Jae

> Thanks for debugging!
> -michael