Re: [PATCH v2 0/8] PCI: qcom: Add support for SC8280XP and SA8540P

From: Bjorn Helgaas
Date: Fri Jul 15 2022 - 18:37:39 EST


On Thu, Jul 14, 2022 at 09:13:40AM +0200, Johan Hovold wrote:
> This series adds support for the PCIe controllers found on SC8280XP and
> SA8540P.

These look fairly straightforward, and I don't mind doing minor tweaks
and conflict resolution, but given that we've got four or five cooks
in the qcom kitchen, I'm looking for an ack from Stan before spending
too much time on this.

> Included are also three patches that clean up the way the driver handles
> different IP revisions (e.g. by modelling optional clocks as being truly
> optional).
>
> These patches depend on the recently merged (but currently held off?)
> PIPE clock series:
>
> https://lore.kernel.org/all/20220608105238.2973600-1-dmitry.baryshkov@xxxxxxxxxx/

As far as I know it's on pci/ctrl/qcom [1], in -next, and ready to go.
It's based on Bjorn A's immutable branch [2].

> as well as the about-to-be-merged MSI series (v17):
>
> https://lore.kernel.org/all/20220707134733.2436629-6-dmitry.baryshkov@xxxxxxxxxx/
>
> Note that the final patch in the PIPE clock series is currently missing
> from the pci/ctrl/qcom-pending branch:
>
> https://lore.kernel.org/all/20220608105238.2973600-6-dmitry.baryshkov@xxxxxxxxxx/

I think I fixed that, let me know if not; see [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=839fbdee4c08
[2] https://lore.kernel.org/linux-pci/YroMyWNO8ZLk1bTe@xxxxxxxxxxx/

> Changes in v2
> - drop the two DT schema fixes which have been applied by Bjorn H and
> squashed into the MSI v17 series by Dmitry, respectively
> - rebase on pci/ctrl/qcom-pending (2022-07-14)
> - fix compatible sort order (Krzysztof)
> - amend commit message for first patch to clarify motivation
> (Krzysztof)
> - add acks and reviewed-by tags from Dmitry, Krzysztof, Mani and Rob
>
>
> Johan Hovold (8):
> dt-bindings: PCI: qcom: Enumerate platforms with single msi interrupt
> dt-bindings: PCI: qcom: Add SC8280XP to binding
> dt-bindings: PCI: qcom: Add SA8540P to binding
> PCI: qcom: Add support for SC8280XP
> PCI: qcom: Add support for SA8540P
> PCI: qcom: Make all optional clocks optional
> PCI: qcom: Clean up IP configurations
> PCI: qcom: Sort device-id table
>
> .../devicetree/bindings/pci/qcom,pcie.yaml | 70 +++++++++-
> drivers/pci/controller/dwc/pcie-qcom.c | 121 +++++++-----------
> 2 files changed, 114 insertions(+), 77 deletions(-)
>
> --
> 2.35.1
>