Re: [PATCH v2] usb: serial: qcserial: add EM9191 support

From: Frans Klaver
Date: Fri Jul 15 2022 - 17:28:41 EST




On July 15, 2022 11:00:45 PM GMT+02:00, Reinhard Speyerer <rspmn@xxxxxxxx> wrote:

>the qcserial driver used in the usb-devices output above does not seem
>to be built from the mainline qcserial.c with your patch applied as USB
>interface 4 is ignored by the QCSERIAL_SWI layout.

Right, I will need to look into that then. I won't be able to access the devices for a couple of weeks, though. It might also just have been me no paying attention while testing. I'll get back to this.


>To avoid potential side effects in case Sierra Wireless adds a vendor class
>USB interface 2 not intended to be used with qcserial.c it might be best
>to use a new QCSERIAL_SWI2 layout similar to what has been done in
>their MBPL drivers mentioned here
>https://forum.sierrawireless.com/t/rc7620-and-linux-driver/24308/ .

I'll have a look at this too.

Thanks,
Frans