Re: [net-next PATCH] net: dsa: qca8k: move driver to qca dir

From: Christian Marangi
Date: Fri Jul 15 2022 - 15:40:00 EST


On Fri, Jul 15, 2022 at 12:37:43PM -0700, Jakub Kicinski wrote:
> On Fri, 15 Jul 2022 03:57:46 +0200 Christian Marangi wrote:
> > > Does the split mean that this code will move again?
> > > If so perhaps better to put this patch in the series
> > > that does the split? We're ~2 weeks away from the merge
> > > window so we don't want to end up moving the same code
> > > twice in two consecutive releases.
> >
> > What to you mean with "will move again"?
> >
> > The code will be split to qca8k-common.c and qca8k-8xxx.c
> > And later qca8k-ipq4019.c will be proposed.
> >
> > So the files will all stay in qca/ dir.
> >
> > Or should I just propose the move and the code split in one series?
>
> Yup that's what I prefer.
>

Ok no problem, if the current merged commit is a problem, np for me with
a revert! (it was really to prevent sending a bigger series, sorry for
the mess)

> > Tell me what do you prefer.

--
Ansuel