Re: [net-next: PATCH v2 1/8] net: phy: fixed_phy: switch to fwnode_ API

[Marcin Wojtas]

pt., 15 lip 2022 o 19:21 Florian Fainelli <f.fainelli@xxxxxxxxx> napisał(a):
>
> On 7/15/22 01:50, Marcin Wojtas wrote:
> > This patch allows to use fixed_phy driver and its helper
> > functions without Device Tree dependency, by swtiching from
> > of_ to fwnode_ API.
> >
> > Signed-off-by: Marcin Wojtas <mw@xxxxxxxxxxxx>
> > ---
> >  include/linux/phy_fixed.h   |  4 +-
> >  drivers/net/mdio/of_mdio.c  |  2 +-
> >  drivers/net/phy/fixed_phy.c | 39 +++++++-------------
> >  3 files changed, 17 insertions(+), 28 deletions(-)
> >
> > diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h
> > index 52bc8e487ef7..449a927231ec 100644
> > --- a/include/linux/phy_fixed.h
> > +++ b/include/linux/phy_fixed.h
> > @@ -19,7 +19,7 @@ extern int fixed_phy_add(unsigned int irq, int phy_id,
> >                        struct fixed_phy_status *status);
> >  extern struct phy_device *fixed_phy_register(unsigned int irq,
> >                                            struct fixed_phy_status *status,
> > -                                          struct device_node *np);
> > +                                          struct fwnode_handle *fwnode);
>
> I think this ought to require a forward declaration of struct fwnode_handle and a removal of the forward declaration of device_node.
>

Ok, I'll replace the declaration.

> With that fixes:
>
> Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
>

Thanks,
Marcin