Re: [PATCH v5 2/3] arm64: dts: qcom: sc7280: Add herobrine-villager-r1

From: Doug Anderson
Date: Fri Jul 15 2022 - 10:14:05 EST


Hi,

On Fri, Jul 15, 2022 at 1:45 AM Jimmy Chen <jinghung.chen3@xxxxxxxxxxx> wrote:
>
> This adds sc7280-herobrine-villager-r1.dts for villager device tree files.
> Herobrine-r1 is exactly the same as -r0 except that it uses a
> different audio solution (it uses the same one as the CRD).
>
> Signed-off-by: Jimmy Chen <jinghung.chen3@xxxxxxxxxxx>
> ---
>
> Changes in v5:
> -Revise rev0+ to rev0
> -Add -r1 line to the Makefile
>
> Changes in v4:
> -Add this patch
>
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/sc7280-herobrine-villager-r0.dts | 4 ++--
> .../boot/dts/qcom/sc7280-herobrine-villager-r1.dts | 14 ++++++++++++++
> 3 files changed, 17 insertions(+), 2 deletions(-)

Other than the unclear race between your series and Judy's patches
[1], this looks good to me now.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

[1] https://lore.kernel.org/r/20220714061151.2126288-4-judyhsiao@xxxxxxxxxxxx