Re: [PATCH] crypto: x86/blowfish: remove redundant assignment to variable nytes

From: Herbert Xu
Date: Fri Jul 15 2022 - 04:49:25 EST


On Thu, Jul 07, 2022 at 09:05:46AM +0100, Colin Ian King wrote:
> Variable nbytes is being assigned a value that is never read, it is
> being re-assigned in the next statement in the while-loop. The
> assignment is redundant and can be removed.
>
> Cleans up clang scan-build warnings, e.g.:
> arch/x86/crypto/blowfish_glue.c:147:10: warning: Although the value
> stored to 'nbytes' is used in the enclosing expression, the value
> is never actually read from 'nbytes'
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
> arch/x86/crypto/blowfish_glue.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt