Re: [PATCH v14 0/5] clk: clocking-wizard: Driver updates

From: Michal Simek
Date: Thu Jul 14 2022 - 07:27:21 EST


Hi Stephen and Michael,

On 4/11/22 12:04, Shubhrajyoti Datta wrote:
The patch does the following
Update the versions of the clocking wizard ip.
Move from staging to clk directory.
Update the bindings.

v12:
No change.
Rebased
v13:
Update the clocking compatible
Add the change removing the driver from staging
v14:
Moved to the xilinx folder

Shubhrajyoti Datta (5):
dt-bindings: add documentation of xilinx clocking wizard
clk: clocking-wizard: Add the clockwizard to clk directory
clk: clocking-wizard: Rename nr-outputs to xlnx,nr-outputs
clk: clocking-wizard: Fix the reconfig for 5.2
clk: clocking-wizard: Update the compatible

.../bindings/clock/xlnx,clocking-wizard.yaml | 77 +++++++++++++++++++
drivers/clk/xilinx/Kconfig | 11 +++
drivers/clk/xilinx/Makefile | 1 +
.../xilinx}/clk-xlnx-clock-wizard.c | 19 +++--
drivers/staging/Kconfig | 2 -
drivers/staging/Makefile | 1 -
drivers/staging/clocking-wizard/Kconfig | 10 ---
drivers/staging/clocking-wizard/Makefile | 2 -
drivers/staging/clocking-wizard/TODO | 13 ----
.../staging/clocking-wizard/dt-binding.txt | 30 --------
10 files changed, 103 insertions(+), 63 deletions(-)
create mode 100644 Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
rename drivers/{staging/clocking-wizard => clk/xilinx}/clk-xlnx-clock-wizard.c (96%)
delete mode 100644 drivers/staging/clocking-wizard/Kconfig
delete mode 100644 drivers/staging/clocking-wizard/Makefile
delete mode 100644 drivers/staging/clocking-wizard/TODO
delete mode 100644 drivers/staging/clocking-wizard/dt-binding.txt


I was looking at comment in v13 and moving to xilinx folder was done in v14.
v13: https://lore.kernel.org/r/cover.1631623906.git.shubhrajyoti.datta@xxxxxxxxxx

dt binding is also reviewed by Rob already.

You asked there to get confirmation from Greg that it can be moved out of staging. I didn't see any reply from Greg about it but not sure if this is really required to get.
Greg: Can you please ACK it or comment?

And in your v13 reply you said that you will pick it up
https://lore.kernel.org/all/20220112204055.CF098C36AE9@xxxxxxxxxxxxxxx/#t
but I can't see this patch in your linux clk tree yet.

I have also see that some people are sending you pull requests to merge it to clock tree. If this is something what you prefer I have really not a problem to do it.

Thanks,
Michal