Re: [PATCH V2 2/2] riscv: Add modules to virtual kernel memory layout dump

[Xianting Tian]

在 2022/7/14 下午4:24, Arnd Bergmann 写道:
> On Thu, Jul 14, 2022 at 4:59 AM Xianting Tian
> <xianting.tian@xxxxxxxxxxxxxxxxx> wrote:
> > As MODULES is only defined for CONFIG_64BIT, so we dump it when
> > CONFIG_64BIT.
> Doesn't this cause a compile-time error on 32-bit?
I tested, rv32 compile is OK.
> >                  (unsigned long)VMEMMAP_END);
> >          print_ml("vmalloc", (unsigned long)VMALLOC_START,
> >                  (unsigned long)VMALLOC_END);
> > +       if (IS_ENABLED(CONFIG_64BIT))
> > +               print_ml("modules", (unsigned long)MODULES_VADDR,
> > +                       (unsigned long)MODULES_END);
> The IS_ENABLED() check prevents the line from getting executed, but
> unlike an #ifdef it still relies on it to be parsable.
Thanks, I will use #ifdef instead of IS_ENABLED
>           Arnd