RE: [PATCH v10 1/2] thermal: Add thermal driver for Sunplus

From: Lh Kuo 郭力豪
Date: Thu Jul 14 2022 - 01:32:34 EST


> > +}
> > +
> > +static int sunplus_thermal_remove(struct platform_device *pdev) {
> > + struct sp_thermal_data *sp_data = platform_get_drvdata(pdev);
> > +
> > + thermal_zone_of_sensor_unregister(&pdev->dev, sp_data->pcb_tz);
>
> You used devm to register, so this looks wrong and will lead to double free.
>
>

You mean the remove function is not needed. ??