Re: [PATCH RESEND -next] lsm_audit: Clean up redundant NULL pointer check

From: Paul Moore
Date: Wed Jul 13 2022 - 22:34:19 EST


On Wed, Jul 13, 2022 at 9:27 PM Xiu Jianfeng <xiujianfeng@xxxxxxxxxx> wrote:
>
> The implements of {ip,tcp,udp,dccp,sctp,ipv6}_hdr(skb) guarantee that
> they will never return NULL, and elsewhere users don't do the check
> as well, so remove the check here.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@xxxxxxxxxx>
> ---
> security/lsm_audit.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)

Hi Xiu Jianfeng,

We just changed LSM maintainers earlier this week, and while I haven't
forgotten about your patch (I reviewed it previously), it is too late
in this current release cycle (-rc6) to merge non-critical fixes.
This would go into the LSM tree after the upcoming merge window.

Thank you for your patience and understanding.

--
paul-moore.com