Re: [PATCH v2 1/1] gpio: mpfs: add polarfire soc gpio support

[Andy Shevchenko]

On Wed, Jul 13, 2022 at 7:44 PM <Conor.Dooley@xxxxxxxxxxxxx> wrote:
> On 13/07/2022 12:59, Andy Shevchenko wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

...

> >> +#define BYTE_BOUNDARY                  0x04
> >
> > Without namespace?
>
> Does byte_boundary even need to be defined?
> is incrementing an address by 0x4 not kinda obvious on its own
> as to what it is doing?

The less magic is the better.

Btw, have you considered gpio-regmap? Can it be utilized here?

-- 
With Best Regards,
Andy Shevchenko