Re: [PATCH] soundwire: qcom: Update error prints to debug prints

From: Pierre-Louis Bossart
Date: Wed Jul 13 2022 - 10:32:11 EST




On 7/13/22 07:22, Srinivasa Rao Mandadapu wrote:
> Upadte error prints to debug prints to avoid redundant logging in kernel

update

> boot time, as these prints are informative prints in irq handler.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
> ---
> drivers/soundwire/qcom.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index 9df970e..a4293d0 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -573,11 +573,10 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id)
> break;
> case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED:
> case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS:
> - dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n",
> - __func__);
> + dev_dbg(swrm->dev, "%s: SWR new slave attached\n", __func__);

any reason why the rate limitation was dropped?

> swrm->reg_read(swrm, SWRM_MCP_SLV_STATUS, &slave_status);
> if (swrm->slave_status == slave_status) {
> - dev_err(swrm->dev, "Slave status not changed %x\n",
> + dev_dbg(swrm->dev, "Slave status not changed %x\n",
> slave_status);
> } else {
> qcom_swrm_get_device_status(swrm);