Re: [PATCH 3/4] dt-bindings: mfd: Add bindings for Samsung SysMgr

From: Rob Herring
Date: Wed Jul 13 2022 - 10:27:06 EST


On Wed, 13 Jul 2022 13:56:28 +0900, Dongjin Yang wrote:
> Add an devicetree binding for Samsung system manager.
> This driver is used for SoCs produced by Samsung Foundry to provide
> Samsung sysmgr API. The read/write request of sysmgr is delivered to
> Samsung secure monitor call.
>
> Signed-off-by: Dongjin Yang <dj76.yang@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/mfd/samsung,sys-mgr.yaml | 42 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/mfd/samsung,sys-mgr.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,sys-mgr.example.dtb: syscon_imem@10020000: reg: [[0, 268566528], [0, 4096]] is too long
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,sys-mgr.example.dtb: syscon@16c20000: reg: [[0, 381812736], [0, 4096]] is too long
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.