Re: [PATCH v2 1/6] gpio: i8255: Introduce the i8255 module

[Andy Shevchenko]

On Wed, Jul 13, 2022 at 12:49 PM William Breathitt Gray
<william.gray@xxxxxxxxxx> wrote:
> On Wed, Jul 13, 2022 at 12:10:51PM +0200, Andy Shevchenko wrote:
> > On Wed, Jul 13, 2022 at 9:40 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > > On Tue, Jul 12, 2022 at 5:06 AM William Breathitt Gray
> > > <william.gray@xxxxxxxxxx> wrote:
> > > > On Mon, Jul 11, 2022 at 03:02:10PM +0200, Linus Walleij wrote:

...

> > > > I think I'll move this to gpio/driver.h as per Andy Shevchenko's
> > >
> > > I don't think this is what Andy meant. I think he suggested moving
> > > this header into drivers/gpio/ because it doesn't make sense for it to
> > > be publicly accessible for anyone else than the GPIO drivers.
> > >
> > > Andy: correct me if I'm wrong.
> >
> > No, you are right. I was talking about localizing the header to drivers/gpio.

> Sure, I can move it to drivers/gpio/i8255.h to keep it local to the GPIO

Please, keep it named in the same pattern as the C-file, but having .h
extension. I believe it's gpio-i8255.h.

> drivers. It'll be trivia to move this out if the need ever arrives in
> the future so I have no problem with that.

Thanks!

-- 
With Best Regards,
Andy Shevchenko