Re: [PATCH 4/6] arm64: dts: imx8mm-kontron: Use upper case PMIC regulator names

From: Frieder Schrempf
Date: Wed Jul 13 2022 - 04:20:42 EST


Am 13.07.22 um 09:52 schrieb Heiko Thiery:
> Hi Frieder,
>
> Am Mi., 13. Juli 2022 um 09:41 Uhr schrieb Frieder Schrempf <frieder@xxxxxxx>:
>>
>> From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
>>
>> Use upper case PMIC regulator names to comply with the bindings.
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
>> ---
>> .../freescale/imx8mm-kontron-n801x-som.dtsi | 22 +++++++++----------
>> 1 file changed, 11 insertions(+), 11 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
>> index 2d0661cce89b..2e3d51bbf92e 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
>> @@ -85,7 +85,7 @@ pca9450: pmic@25 {
>>
>> regulators {
>> reg_vdd_soc: BUCK1 {
>> - regulator-name = "buck1";
>> + regulator-name = "BUCK1";
>
> Wouldn't it be better to use the real signal or voltage rail names
> used in the schematics?

Sounds like a good idea, thanks! I will try to include in the next
version of this patchset.