Re: [PATCH v6 1/4] spi: dw: Fix IP-core versions macro

From: Serge Semin
Date: Wed Jul 13 2022 - 01:36:30 EST


On Wed, Jul 13, 2022 at 12:22:20PM +0800, nandhini.srikandan@xxxxxxxxx wrote:
> From: Nandhini Srikandan <nandhini.srikandan@xxxxxxxxx>
>
> Add the missing underscore in IP version macro to avoid compilation issue.
> The macro is used for IP version comparison in the current patchset.
>
> Fixes: 2cc8d9227bbb ("spi: dw: Introduce Synopsys IP-core versions interface")
> Signed-off-by: Nandhini Srikandan <nandhini.srikandan@xxxxxxxxx>

Thanks.
Acked-by: Serge Semin <fancer.lancer@xxxxxxxxx>

-Sergey

> ---
> drivers/spi/spi-dw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h
> index d5ee5130601e..79d853f6d192 100644
> --- a/drivers/spi/spi-dw.h
> +++ b/drivers/spi/spi-dw.h
> @@ -23,7 +23,7 @@
> ((_dws)->ip == DW_ ## _ip ## _ID)
>
> #define __dw_spi_ver_cmp(_dws, _ip, _ver, _op) \
> - (dw_spi_ip_is(_dws, _ip) && (_dws)->ver _op DW_ ## _ip ## _ver)
> + (dw_spi_ip_is(_dws, _ip) && (_dws)->ver _op DW_ ## _ip ## _ ## _ver)
>
> #define dw_spi_ver_is(_dws, _ip, _ver) __dw_spi_ver_cmp(_dws, _ip, _ver, ==)
>
> --
> 2.17.1
>