Re: [PATCH v2] platform/chrome: cros_ec: Send host event for prepare/complete

[Tzung-Bi Shih]

On Wed, Jul 06, 2022 at 08:51:39PM -0600, Tim Van Patten wrote:
> Update cros_ec_lpc_pm_ops to call cros_ec_lpc_suspend() during PM
> .prepare() and cros_ec_lpc_resume() during .complete. This allows the
> EC to log entry/exit of AP's suspend/resume more accurately.

Please be consistent.  Either way:
- .prepare and .complete.
- .prepare() and .complete().

The patch doesn't allow EC to log anything.  It makes AP emit more logs.

On the related note, the commit subject is confusing.  The patch doesn't
send "host event".  "host event" is a terminology when EC wants to notify
AP something.  Also, s/cros_ec/cros_ec_lpcs/.

> Changes in v2:
> - Include cros_ec_resume() return value in dev_info() output.
> - Guard setting .prepare/.complete with #ifdef CONFIG_PM_SLEEP.

I didn't see concerns in [1] have been addressed.

[1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220701095421.1.I78ded92e416b55de31975686d34b2058d4761c07@changeid/#24920824