RE: [Patch v4 01/12] net: mana: Add support for auxiliary device

From: Long Li
Date: Tue Jul 12 2022 - 14:26:25 EST


> Subject: RE: [Patch v4 01/12] net: mana: Add support for auxiliary device
>
> > From: longli@xxxxxxxxxxxxxxxxx <longli@xxxxxxxxxxxxxxxxx>
> > Sent: Wednesday, June 15, 2022 7:07 PM
> ...
> > +static int add_adev(struct gdma_dev *gd) {
> > + int ret = 0;
> No need to initialize it to 0.
>
> > + struct mana_adev *madev;
> > + struct auxiliary_device *adev;
>
> davem would require the reverse xmas tree order :-)

Thank you, will send v5 to fix this.

>
> Reviewed-by: Dexuan Cui <decui@xxxxxxxxxxxxx>