Re: [PATCH 1/2] perf test: Add debug line to diagnose broken metrics

[Arnaldo Carvalho de Melo]

Em Thu, Jul 07, 2022 at 08:34:48AM -0700, Ian Rogers escreveu:
> Printing out the metric name and architecture makes finding the source
> of a failure easier.

Thanks, applied both patches.

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
>  tools/perf/tests/pmu-events.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/tests/pmu-events.c b/tools/perf/tests/pmu-events.c
> index f13368569d8b..478b33825790 100644
> --- a/tools/perf/tests/pmu-events.c
> +++ b/tools/perf/tests/pmu-events.c
> @@ -1115,6 +1115,7 @@ static int test__parsing_fake(struct test_suite *test __maybe_unused,
>  				break;
>  			if (!pe->metric_expr)
>  				continue;
> +			pr_debug("Found metric '%s' for '%s'\n", pe->metric_name, map->cpuid);
>  			err = metric_parse_fake(pe->metric_expr);
>  			if (err)
>  				return err;
> -- 
> 2.37.0.rc0.161.g10f37bed90-goog

-- 

- Arnaldo